Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: migrate EvalTest to JUnit 5 #4495

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testStringConcatenation
  • Replaced junit 4 test annotation with junit 5 test annotation in testArrayLength
  • Replaced junit 4 test annotation with junit 5 test annotation in testDoNotSimplify
  • Replaced junit 4 test annotation with junit 5 test annotation in testDoNotSimplifyCasts
  • Replaced junit 4 test annotation with junit 5 test annotation in testScanAPartiallyEvaluatedElement
  • Replaced junit 4 test annotation with junit 5 test annotation in testTryCatchAndStatement
  • Replaced junit 4 test annotation with junit 5 test annotation in testDoNotSimplifyToExpressionWhenStatementIsExpected
  • Replaced junit 4 test annotation with junit 5 test annotation in testIsKnownAtCompileTime
  • Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluator_binary
  • Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluator_unary
  • Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluator_if
  • Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluatorScanner
  • Replaced junit 4 test annotation with junit 5 test annotation in testconvertElementToRuntimeObject

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testStringConcatenation
  • Transformed junit4 assert to junit 5 assertion in testArrayLength
  • Transformed junit4 assert to junit 5 assertion in testDoNotSimplify
  • Transformed junit4 assert to junit 5 assertion in testDoNotSimplifyCasts
  • Transformed junit4 assert to junit 5 assertion in testScanAPartiallyEvaluatedElement
  • Transformed junit4 assert to junit 5 assertion in testTryCatchAndStatement
  • Transformed junit4 assert to junit 5 assertion in testDoNotSimplifyToExpressionWhenStatementIsExpected
  • Transformed junit4 assert to junit 5 assertion in testIsKnownAtCompileTime
  • Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluator_binary
  • Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluator_unary
  • Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluator_if
  • Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluatorScanner
  • Transformed junit4 assert to junit 5 assertion in testconvertElementToRuntimeObject

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testStringConcatenation
Replaced junit 4 test annotation with junit 5 test annotation in testArrayLength
Replaced junit 4 test annotation with junit 5 test annotation in testDoNotSimplify
Replaced junit 4 test annotation with junit 5 test annotation in testDoNotSimplifyCasts
Replaced junit 4 test annotation with junit 5 test annotation in testScanAPartiallyEvaluatedElement
Replaced junit 4 test annotation with junit 5 test annotation in testTryCatchAndStatement
Replaced junit 4 test annotation with junit 5 test annotation in testDoNotSimplifyToExpressionWhenStatementIsExpected
Replaced junit 4 test annotation with junit 5 test annotation in testIsKnownAtCompileTime
Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluator_binary
Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluator_unary
Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluator_if
Replaced junit 4 test annotation with junit 5 test annotation in testVisitorPartialEvaluatorScanner
Replaced junit 4 test annotation with junit 5 test annotation in testconvertElementToRuntimeObject
Transformed junit4 assert to junit 5 assertion in testStringConcatenation
Transformed junit4 assert to junit 5 assertion in testArrayLength
Transformed junit4 assert to junit 5 assertion in testDoNotSimplify
Transformed junit4 assert to junit 5 assertion in testDoNotSimplifyCasts
Transformed junit4 assert to junit 5 assertion in testScanAPartiallyEvaluatedElement
Transformed junit4 assert to junit 5 assertion in testTryCatchAndStatement
Transformed junit4 assert to junit 5 assertion in testDoNotSimplifyToExpressionWhenStatementIsExpected
Transformed junit4 assert to junit 5 assertion in testIsKnownAtCompileTime
Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluator_binary
Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluator_unary
Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluator_if
Transformed junit4 assert to junit 5 assertion in testVisitorPartialEvaluatorScanner
Transformed junit4 assert to junit 5 assertion in testconvertElementToRuntimeObject
@slarse slarse merged commit 4468c96 into INRIA:master Jan 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants