Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: migrate FactoryTest to JUnit 5 #4530

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testClone
  • Replaced junit 4 test annotation with junit 5 test annotation in testFactoryOverriding
  • Replaced junit 4 test annotation with junit 5 test annotation in testClassAccessCreatedFromFactories
  • Replaced junit 4 test annotation with junit 5 test annotation in testCtModel
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetPackageFromNamedModule
  • Replaced junit 4 test annotation with junit 5 test annotation in specificationCoreFactoryCreate
  • Replaced junit 4 test annotation with junit 5 test annotation in factoryTest

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testClone
  • Transformed junit4 assert to junit 5 assertion in testFactoryOverriding
  • Transformed junit4 assert to junit 5 assertion in testClassAccessCreatedFromFactories
  • Transformed junit4 assert to junit 5 assertion in testCtModel
  • Transformed junit4 assert to junit 5 assertion in testGetPackageFromNamedModule
  • Transformed junit4 assert to junit 5 assertion in specificationCoreFactoryCreate
  • Transformed junit4 assert to junit 5 assertion in factoryTest

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testClone
Replaced junit 4 test annotation with junit 5 test annotation in testFactoryOverriding
Replaced junit 4 test annotation with junit 5 test annotation in testClassAccessCreatedFromFactories
Replaced junit 4 test annotation with junit 5 test annotation in testCtModel
Replaced junit 4 test annotation with junit 5 test annotation in testGetPackageFromNamedModule
Replaced junit 4 test annotation with junit 5 test annotation in specificationCoreFactoryCreate
Replaced junit 4 test annotation with junit 5 test annotation in factoryTest
Transformed junit4 assert to junit 5 assertion in testClone
Transformed junit4 assert to junit 5 assertion in testFactoryOverriding
Transformed junit4 assert to junit 5 assertion in testClassAccessCreatedFromFactories
Transformed junit4 assert to junit 5 assertion in testCtModel
Transformed junit4 assert to junit 5 assertion in testGetPackageFromNamedModule
Transformed junit4 assert to junit 5 assertion in specificationCoreFactoryCreate
Transformed junit4 assert to junit 5 assertion in factoryTest
@monperrus monperrus merged commit fbdc7a9 into INRIA:master Jan 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants