Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: migrate TypeFactoryTest to JUnit 5 #4532

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testCreateTypeRef
  • Replaced junit 4 test annotation with junit 5 test annotation in reflectionAPI
  • Replaced junit 4 test annotation with junit 5 test annotation in reflectionAPIWithTypeParameter
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetClassInAnInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetClassWithDollarAndNestedClass

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testCreateTypeRef
  • Transformed junit4 assert to junit 5 assertion in reflectionAPI
  • Transformed junit4 assert to junit 5 assertion in reflectionAPIWithTypeParameter
  • Transformed junit4 assert to junit 5 assertion in testGetClassInAnInterface
  • Transformed junit4 assert to junit 5 assertion in testGetClassWithDollarAndNestedClass

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testCreateTypeRef
Replaced junit 4 test annotation with junit 5 test annotation in reflectionAPI
Replaced junit 4 test annotation with junit 5 test annotation in reflectionAPIWithTypeParameter
Replaced junit 4 test annotation with junit 5 test annotation in testGetClassInAnInterface
Replaced junit 4 test annotation with junit 5 test annotation in testGetClassWithDollarAndNestedClass
Transformed junit4 assert to junit 5 assertion in testCreateTypeRef
Transformed junit4 assert to junit 5 assertion in reflectionAPI
Transformed junit4 assert to junit 5 assertion in reflectionAPIWithTypeParameter
Transformed junit4 assert to junit 5 assertion in testGetClassInAnInterface
Transformed junit4 assert to junit 5 assertion in testGetClassWithDollarAndNestedClass
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants