Resolve Literal#constant if required. Fixes #755. #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases (an example is given in INRIA#755) Literal#constant may be `null` and, thus, causes a NullPointerException when calling `localDeclaration.initialization.traverse(this, scope);`. This patch fixes the issue by resolving Literal#constant if required.
|
Excellent, thanks! Would you add a test case showing that the bug has disappeared? |
|
AppVayor seems to fail for bad reasons here. I relaunched it. @ReTuXx do you find time to add a test case on your PR? |
|
Working on it. |
|
Thanks! :) If you need help, come back to us. |
In case of a StringLiteral type resolution must be omitted is scope is null. Otherwise, a NullPointerException is thrown.
|
Test case has been added. Fixed another issue that occurs if a Literal is a StringLiteral and scope is null. |
|
Oh sorry, looks like I forgot to check style guide. |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (an example is given in #755) Literal#constant may
be
nulland, thus, causes a NullPointerException when callinglocalDeclaration.initialization.traverse(this, scope);. Thispatch fixes the issue by resolving Literal#constant if required.