feat(position): improve the element positions #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurieux
force-pushed
the
feat_position
branch
3 times, most recently
from
2b68632 to
769674e
Compare
monperrus
reviewed
Nov 17, 2016
| @@ -14,16 +14,67 @@ | |||
| * The fact that you are presently reading this means that you have had | |||
| * knowledge of the CeCILL-C license and that you accept its terms. | |||
| */ | |||
| package spoon.reflect.cu; | |||
monperrus
reviewed
Nov 17, 2016
| @@ -376,7 +379,30 @@ | |||
| */ | |||
| SourcePosition createSourcePosition( | |||
| CompilationUnit compilationUnit, | |||
| int startDeclaration, int startSource, int end, int[] lineSeparatorPositions); | |||
|
some doc in /doc |
tdurieux
force-pushed
the
feat_position
branch
4 times, most recently
from
bff6a48 to
118ec53
Compare
monperrus
reviewed
Nov 22, 2016
| public interface SourcePosition { | ||
| public interface SourcePosition extends Serializable { | ||
|
|
||
| SourcePosition NOPOSITION = new SourcePosition() { |
There was a problem hiding this comment.
singleton outside, declaration here
tdurieux
force-pushed
the
feat_position
branch
from
118ec53 to
174b7bf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.