Messages silenced in write and graph. #526
Conversation
There were 3 total logging calls that were clogging the output and appear to be leftover from some past debugging. They just print large lists of numbers and aren't really indicating anything to the user.
|
This build fails on a single test. The URL for the assertion needs to be readjusted: |
isatools/isatab/dump/write.py
Outdated
| @@ -59,7 +59,7 @@ def flatten(current_list): | |||
| paths = _all_end_to_end_paths( | |||
| s_graph, | |||
| [x for x in s_graph.nodes() if isinstance(s_graph.indexes[x], Source)]) | |||
| log.warning(s_graph.nodes()) | |||
| # log.warning(s_graph.nodes()) | |||
There was a problem hiding this comment.
No comments in production: please delete the commented lines instead (Same for the graph.py file)
There was a problem hiding this comment.
I just made another commit that deletes them instead. Are comments not allowed at all or just commenting out code? There are definitely comments throughout the code.
There was a problem hiding this comment.
@ptth222 There are a LOT of comments (way too manu) through the code because of how people used to work. I never had time to prune everything from the source code but I'm trying to make sure we don't introduce more into prod.
Comments are allowed, not commented code.
Deleted the logging lines instead of commenting them out as requested.
|
Incorporated in #551. |
There were 3 total logging calls that were clogging the output and appear to be leftover from some past debugging. They just print large lists of numbers and aren't really indicating anything to the user.