-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix for graph height declared in template #262
Conversation
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: SFS sapadm.
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @dheule
|
@cla-bot check |
Hi @nilmerg , I have only added the parameter processing from the height graph template to the render view, this is working. But for Pie graphs, you also need a fixed width. I will look at this at the next few weeks, atm i have no time to implemnt this asap. So please stay tuned for the next update. This pull request only helps for normal graphs with needs a bigger height. Best regards, |
Now i have updated the fix for 1.2 and added the handling of width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks correct now. No matter if I define only a width, or height, or both. 👍
This shuld fix #234