-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
support carbonapi #328
base: main
Are you sure you want to change the base?
support carbonapi #328
Conversation
Tested it in my environment as well. Works flawlessly so far. THANK YOU! |
It also works perfectly in our environment. Thank you very much. |
Just to be sure, this keeps 100% compatibility with how it worked before? |
We use another API endpoint now. The return of the API is a little bit different, which is why the data is stored slightly differently into the results. Based on the API endpoint documentations that will work with all possible components. Besides of that it works how it worked before. Long story short: |
While working on another topic for the module I have found a difference that will break the current behaviour. The changes merge graphs with placeholders into one * and only one graph is rendered. Please wait for that before merging! |
To solve the problem mentioned above, deep changes to the module are necessary, which would significantly change the behaviour. If you (Icinga) are interested in supporting the current stack around Graphite, I would be happy to provide further information on which steps would need to be adapted from the Graphite / CarbonApi perspective. |
This PR not only adds support for carbonapi, it supports graphite-api which implements API version 0.9.8 and carbonapi which implements the necessary endpoints of API version 1.11.7 (and not metrics/expand).
Endpoint Documentation:
I have tested it with the latest available graphite-api and carbonapi v0.16.0
Possible solution for #300
Feedback welcome!
CC @dgoetz