NameID input from attributes for LDAP attribute store #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to specify that attributes returned from the LDAP directory server used with the LDAP attribute store should be used as input to be hashed for the NameID for a persistent name identifier sent to a SP.
jkakavas
reviewed
Jun 7, 2017
| # LDAP directory server may return multi-valued attributes | ||
| # in any order. | ||
| value.sort() | ||
| for v in value: |
There was a problem hiding this comment.
probably nitpicking :) but userId = "".join(value) should be more efficient than the for loop + string concat and still be readable
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to specify that attributes returned from
the LDAP directory server used with the LDAP attribute store
should be used as input to be hashed for the NameID for a
persistent name identifier sent to a SP.