Feature refactor saml modules #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 26, 2017 18:12
c00kiemon5ter
commented
Jul 26, 2017
|
|
||
| auth_info = {} | ||
| if self.acr_mapping: | ||
| auth_info["class_ref"] = self.acr_mapping.get(internal_response.auth_info.issuer, self.acr_mapping[""]) | ||
| auth_info["class_ref"] = self.acr_mapping.get( | ||
| internal_response.auth_info.issuer, self.acr_mapping[""]) |
There was a problem hiding this comment.
I think we could switch to get_dict_defaults() here, instead of manually trying the "" key.
I think this happens elsewhere too, and we can agree that get_dict_defaults should dictate on how fallback keys should be checked (as a reminder there are two special/fallback keys: "" and "default").
c00kiemon5ter
force-pushed
the
feature-refactor-saml-modules
branch
from
b1491d9 to
e87af90
Compare
|
This PR makes the code much more readable. I will merge it if no one else has something to add. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset is a generic cleanup on the saml base, frontend and backend modules.
I tried to make the code simpler and more readable, while avoiding repetition.
The general idea is that configuration keys should not be magic values all over the code and thus should be defined in the modules that uses the keys. Initialisation of common keys in the front and back end are handled by the base module.
While the changes may look a lot, most are formatting changes (whitespace, max line length, etc) and there are only a couple of actual code changes on how fallbacks are handled.
These happen on backend's
__init__regardingkey_file_pathsand on the frontend's_handle_authn_responsefunction regarding howpolicysettings are accessed to gather info aboutsign_assertion,sign_response,sign_alganddigest_alg.PS: It should be easier to look at each commit separately