Skip to content

fix(input-group): fluent theme discrepancies #15700

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Apr 15, 2025
Merged

Conversation

SisIvanova
Copy link
Collaborator

Related to IgniteUI/igniteui-theming/issues/393

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

didimmova
didimmova previously approved these changes Apr 9, 2025
@adrianptrv adrianptrv added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 9, 2025
@didimmova didimmova self-requested a review April 10, 2025 05:18
didimmova
didimmova previously approved these changes Apr 10, 2025
@yradoeva
Copy link

[Angular] Input, Search, Combo, Select, Text area, Date Picker (maybe also Time Picker, but couldn't check)
Bottom margin of the label should be 5px
image

@simeonoff simeonoff merged commit 044db87 into master Apr 15, 2025
1 check passed
@simeonoff simeonoff deleted the sivanova/fluent-inputs branch April 15, 2025 05:39
@simeonoff
Copy link
Collaborator

@yradoeva Sorry, merged before seeing your comments, Sisi will create a new PR with the requested changes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluent: Input Group - discrepancies between Figma design and implementation
5 participants