Add dialog samples #298
Merged
Add dialog samples #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igdmdimitrov
requested review from
ChronosSF
and removed request for
igdmdimitrov
|
In the Overview and Closing Variations samples an error is thrown in Console when closing the dialog by clicking one of the buttons: It's probably the dialog.hide() that needs to be used on button click instead of dialog.close(). |
mtsvyatkova
added
status: in-development
mtsvyatkova
added
status: in-test
status: verified
ChronosSF
previously requested changes
Nov 2, 2022
browser/package.json
Outdated
| @@ -27,17 +27,6 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@igniteui/material-icons-extended": "2.11.0", | |||
| "@infragistics/igniteui-webcomponents-charts": "22.2.4", | |||
ChronosSF
approved these changes
Nov 2, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252