Skip to content

Fixed state persistence sample- checking & unchecking options #856

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

MarielaTihova
Copy link
Contributor

Resolves #855

@tishko0
Copy link
Contributor

tishko0 commented Nov 29, 2024

It seems deselecting a feature does not really disable this feature. While the button does deselect all features, I can still sort, select columns, etc.

@tishko0 tishko0 added the status: in-review PR ready for review label Nov 29, 2024
@MarielaTihova
Copy link
Contributor Author

It seems deselecting a feature does not really disable this feature. While the button does deselect all features, I can still sort, select columns, etc.

As discussed, this is by design. Not an issue caused by this PR. If we want different behaviour, this should be a feature request. @dkamburov

@tishko0 tishko0 added status: verified The PR is tested and ready for a merge and removed status: in-review PR ready for review labels Jan 28, 2025
@dkamburov dkamburov merged commit 3cee2c3 into vnext Mar 13, 2025
4 checks passed
@dkamburov dkamburov deleted the mtihova/fix-855 branch March 13, 2025 10:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: verified The PR is tested and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State Persistence Sample: Toggling 'All Features' checkbox does not work as expected
4 participants