Skip to content

Commit

Permalink
Merge pull request #78 from ImperialCollegeLondon/dev
Browse files Browse the repository at this point in the history
Update software to v5.1.1
  • Loading branch information
mfacchinelli authored Sep 12, 2024
2 parents 288cfe4 + 9fbe406 commit f71963a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 32 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/matlab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
if: github.ref == 'refs/heads/main'
needs: test
env:
VERSION: "5.1.0"
VERSION: "5.1.1"
steps:
- name: Check out repository
uses: actions/checkout@v4
Expand Down
28 changes: 1 addition & 27 deletions resources/release-notes.md
Original file line number Diff line number Diff line change
@@ -1,29 +1,3 @@
# App

## Fixes

- Add placeholders for CPT settings with dynamic defaults
- Disable "Save Figures" and "Close Figures" buttons after using "Close Figures"
- Fix issues with validation of CPT primary and secondary modes, and range patterns (`mag.app.control.CPT`)
- Fix AppDesigner app `DataVisualization_AppDesigner.mlapp` class name

## Refactoring

- Refactor `mag.app.control.Control/visualize` methods to return command (`mag.app.Command`) to be run for visualization
- Redesign `mag.app.control.StartEndDate/addStartEndDateButtons` signature to be more flexible
- Redesign `mag.app.control.Filter/addFilterButtons` signature to be more flexible
- Move `cropResults` definition from `mag.app.control.Control` to `mag.app.internal.cropResults`

# Software

- Add support in `mag.Instrument/crop`, `mag.Science/select`, and `mag.graphics.view.Field/visualize` for empty science

# Tests

- Add tests for `mag.app.control.Field`, `mag.app.control.PSD`, and `mag.app.control.Spectrogram`
- Add tests for `mag.app.Command` and `mag.app.internal.combineDateAndTime`
- Add tests for `mag.hk.Science`

# Build

- Include coverage for `app` folder
- Fix typo in arguments to `mag.graphics.view.PSD` view in `mag.graphics.sftPlots`
6 changes: 3 additions & 3 deletions src/analyze/+mag/+process/Filter.m
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@
data = this.cropDataWithRange(data, times', this.OnLongPause);
end

% Filter out between config and ramp mode.
% Ramp mode is surrounded by two config modes. Remove data from
% the first to the last config.
% Filter out between Config and ramp mode.
% Ramp mode is surrounded by two Config modes. Remove data from
% the first to the last Config.
if isa(events, "eventtable")

locConfig = contains(events.Label, "Config");
Expand Down
2 changes: 1 addition & 1 deletion src/visualize/+mag/+graphics/sftPlots.m
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
m.crop([seconds(30), seconds(-30)]);
end

views(end + 1) = mag.graphics.view.PSD(m, PSDStart = options.PSDStart, PSDDuration = options.PSDDuration);
views(end + 1) = mag.graphics.view.PSD(m, Start = options.PSDStart, Duration = options.PSDDuration);
end
end

Expand Down

0 comments on commit f71963a

Please # to comment.