Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Upgrade mypy to fix test error in CI for python 3.10 #21

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

AdrianDAlessandro
Copy link
Contributor

This fixes the error where mypy tests are failing in Python version 3.10 for inexplicable reasons. It was a bug in mypy that has been fixed

Close #16

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #21 (40f3af8) into develop (e7e4fb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #21   +/-   ##
========================================
  Coverage    92.24%   92.24%           
========================================
  Files            3        3           
  Lines          129      129           
========================================
  Hits           119      119           
  Misses          10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dalonsoa dalonsoa merged commit 1eede8d into ImperialCollegeLondon:develop Oct 26, 2022
@dalonsoa
Copy link
Collaborator

@all-contributors please add @AdrianDAlessandro for bugs and code

@allcontributors
Copy link
Contributor

@dalonsoa

I've put up a pull request to add @AdrianDAlessandro! 🎉

@AdrianDAlessandro AdrianDAlessandro deleted the mypy-bug branch October 31, 2022 12:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy fails in the CI with Python 3.10
2 participants