Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add cache support #170

Merged
merged 14 commits into from
Apr 24, 2018
Merged

Add cache support #170

merged 14 commits into from
Apr 24, 2018

Conversation

MekDrop
Copy link
Member

@MekDrop MekDrop commented Feb 11, 2018

Implements #162.

Now admin_menu, editors_list and waiting block uses caching lib for cache own data. At current moment only file caching is enabled.

@MekDrop MekDrop added this to the 2.0.0 milestone Feb 11, 2018
@MekDrop MekDrop requested review from skenow and fiammybe February 11, 2018 20:51
@fiammybe
Copy link
Member

fiammybe commented Mar 3, 2018

Looks like I have an issue with this one on the admin.php page :

Message: Integer or \DateTime object expected.
Code: 0
File: C:\xampp56\htdocs\prepa6\vendor\apix\cache\src\PsrCache\Item.php
Line: 191
Trace:
#0 C:\xampp56\htdocs\prepa6\vendor\apix\cache\src\PsrCache\Item.php(71): Apix\Cache\PsrCache\Item->expiresAt(1519888082)
#1 C:\xampp56\htdocs\prepa6\vendor\apix\cache\src\PsrCache\TaggablePool.php(52): Apix\Cache\PsrCache\Item->__construct('waiting_touch', NULL, 1519888082, false)
#2 C:\xampp56\htdocs\prepa6\modules\system\blocks\system_waiting.php(24): Apix\Cache\PsrCache\TaggablePool->getItem('waiting_touch')
#3 C:\xampp56\htdocs\prepa6\libraries\icms\view\block\Object.php(262): b_system_waiting_show(Array)
#4 C:\xampp56\htdocs\prepa6\libraries\icms\view\PageBuilder.php(286): icms_view_block_Object->buildBlock()
#5 C:\xampp56\htdocs\prepa6\libraries\icms\view\PageBuilder.php(128): icms_view_PageBuilder->buildBlock(Object(icms_view_block_Object), Object(icms_view_Tpl))
#6 C:\xampp56\htdocs\prepa6\libraries\icms\view\PageBuilder.php(69): icms_view_PageBuilder->retrieveBlocks()
#7 C:\xampp56\htdocs\prepa6\libraries\icms\view\theme\Object.php(242): icms_view_PageBuilder->xoInit()
#8 C:\xampp56\htdocs\prepa6\libraries\icms\view\theme\Factory.php(109): icms_view_theme_Object->xoInit()
#9 C:\xampp56\htdocs\prepa6\libraries\icms\response\HTML.php(433): icms_view_theme_Factory->createInstance(Array)
#10 C:\xampp56\htdocs\prepa6\libraries\icms\response\HTML.php(35): icms_response_HTML->setThemeFromConfig(Array)
#11 C:\xampp56\htdocs\prepa6\include\cp_functions.php(66): icms_response_HTML->__construct(Array)
#12 C:\xampp56\htdocs\prepa6\admin.php(82): icms_cp_header()
#13 {main}

@MekDrop
Copy link
Member Author

MekDrop commented Mar 4, 2018

I think I have fixed this one too.

@fiammybe fiammybe modified the milestones: 2.0.0, 2.0.0 alpha6 Mar 19, 2018
@fiammybe fiammybe modified the milestones: 2.0.0, 2.0.0 alpha7 Apr 15, 2018
@MekDrop
Copy link
Member Author

MekDrop commented Apr 23, 2018

Test, merge #203 first. Than I'll be able to fix this one.

@fiammybe fiammybe merged commit 1321978 into ImpressCMS:retro Apr 24, 2018
@MekDrop MekDrop deleted the Add-Cache-Support branch April 24, 2018 22:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants