Fix and improve German translation #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two lines were accidentally reverted in ImranR98#2057 due to a merge conflict.
- Increase consistency for certain terms - Address concerns for the translation of _author_ containing a colon by using a different wording - Minor improvements
|
I think it makes sense to go with Publisher for the reasons you outlined. May make the same change in English later. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As discussed in #2059. This addresses some concerns voiced in that PR)
@DwainZwerg feel free to take a look.
This slightly changes the meaning of author to publisher. In my opinion publisher instead of author better reflects the actual context in English as well. Why? While uisng e.g. GitHub as source, Obtainium will show the user or org from the repository. In case of single-dev apps this is often the actual author, but you may argue that for example Fossify is not considered the author of Fossify Gallery, but multiple contributors are. This is just a nitpick though and some may argue otherwise.
However, e.g. with IzzyOnDroid, Obtainium does not show the actual maintainer of the app, but rather only shows IzzyOnDroid in Obtainium's app overview. Izzy is certainly not the author of those apps, but the person publishing/uploading them to their repository.
Thus using the word publisher instead of author should be evaluated since it more broadly reflects what Obtainium currently wants to say with this term.
What's your @ImranR98 and community's opinion on this?
(I do realize that this is just a nit and many likely won't ever care or notice this)