CI: Update compile-platform-examples.yml #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinjingZhang
force-pushed
the
fix-upload-artifact-v3-deprecated
branch
from
c72ea2a to
9cec094
Compare
jaenrig-ifx
reviewed
Feb 12, 2025
| @@ -194,9 +194,14 @@ jobs: | |||
| enable-deltas-report: false | |||
| sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} | |||
|
|
|||
| - name: Modify the environment variable | |||
There was a problem hiding this comment.
Is this step required? Can you just not use ${{ matrix.board.fqbn }} already in the naming of line 206?
There was a problem hiding this comment.
Unfortunately, colons are not allowed in names, so I had to add this step.
There was a problem hiding this comment.
All good, anyhow, this action is not currently used in the arduino-core-tests. And might not be used.
Still, we are using this action for uploading things in other places. So good to know they have change this behaviour.
jaenrig-ifx
approved these changes
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Compilation test is not running due to deprecation of upload-artifact.
Related Issue
actions/upload-artifact#478
It seems that upload-artifacts v4 does not allow all outputs in the build matrix to be uploaded to one folder.
So now artifact is uploaded under different board names.
Context