-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add Edge authentication support #111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 89.29% 95.81% +6.51%
==========================================
Files 12 12
Lines 1093 1098 +5
Branches 140 141 +1
==========================================
+ Hits 976 1052 +76
+ Misses 80 11 -69
+ Partials 37 35 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! 👍 Before we can proceed with accepting it, there are a few requirements that need to be met:
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
bfc8ce2
to
933cadd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Proposed Changes
Adds
authScheme
option toInfluxDBClient
initialization (via config, connection string or environment variables) to allow setting token authentication scheme other then the default"Token"
(used for Cloud). For Edge (OSS), users need to set it to"Bearer"
.Checklist