Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: uniform client API #35

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Aug 1, 2023

Proposed Changes

Uniform future client API.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #35 (18541b8) into feat/proxy-custom-headers (3c3f9ce) will not change coverage.
The diff coverage is 100.00%.

@@                     Coverage Diff                     @@
##           feat/proxy-custom-headers       #35   +/-   ##
===========================================================
  Coverage                     100.00%   100.00%           
===========================================================
  Files                             12        12           
  Lines                            788       788           
===========================================================
  Hits                             788       788           
Files Changed Coverage Δ
Client/Config/WriteOptions.cs 100.00% <ø> (ø)
Client/Config/ClientConfig.cs 100.00% <100.00%> (ø)
Client/InfluxDBClient.cs 100.00% <100.00%> (ø)
Client/Internal/FlightSqlClient.cs 100.00% <100.00%> (ø)
Client/Internal/RestClient.cs 100.00% <100.00%> (ø)

@alespour alespour requested a review from bednar August 1, 2023 12:18
@bednar bednar marked this pull request as ready for review August 1, 2023 12:21
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍. There is only one requirement:

  1. Please update also README.md to new naming

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@alespour alespour force-pushed the fix/uniform-client-api branch from b24ae3e to 18541b8 Compare August 3, 2023 13:49
@alespour alespour merged commit b5b5770 into feat/proxy-custom-headers Aug 3, 2023
@alespour alespour deleted the fix/uniform-client-api branch August 3, 2023 13:53
@bednar bednar added this to the 0.2.0 milestone Aug 7, 2023
alespour added a commit that referenced this pull request Aug 7, 2023
* feat: add HTTP proxy and custom headers support

* fix: uniform client API (#35)

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants