Make everything async #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have to take a closer look this weekend, but I'm interested in switching things over to async since it seems to be a better fit for UIs in general. Exciting 😄 |
|
Since this has some overlap with #69 I'm okay with handling getting this merged first and then I can rebase that branch on top btw |
|
I actually did this branch over #69 initially and just seperated them. I'll merge yours tonight and then rebase this since I already have the code for it. |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Tokio to make everything async instead of using threads. This mainly impacts image loading which used to use thread spacing before. I feel as though this is a bit cleaner at the cost of feeling a bit 'magic-like'. I'm interested to hear your thoughts about this @CosmicHorrorDev.
I haven't done any benchmarking against the old implementation yet. This should help with streaming images directly into a compressed format.