Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FIX] Compatibility Keycloak 21 #86

Merged
merged 1 commit into from
Jun 21, 2023
Merged

[FIX] Compatibility Keycloak 21 #86

merged 1 commit into from
Jun 21, 2023

Conversation

clement-dufaure
Copy link
Collaborator

No description provided.

@clement-dufaure
Copy link
Collaborator Author

Fix #85

@clement-dufaure clement-dufaure marked this pull request as draft March 3, 2023 23:04
This was referenced Mar 3, 2023
Closed
Closed
@mboisnard
Copy link
Contributor

mboisnard commented Mar 3, 2023 •
edited
Loading

Hey :)
I think there is a blocker with Keycloak 21 version since the Keycloak team removed the old admin interface without implementing custom provider page in the new interface. So the plugin cannot be configured for now ...

keycloak/keycloak#15344 (comment)

@clement-dufaure
Copy link
Collaborator Author

Thanks to external tests, it seems that actual config is not impacted by upgrading to kc 21 and upgrading to this version of plugin france connect.
I'll probably publish this release with a huge warning, like "only for bumping from an older keycloak version but no longer settable in admin ui"

@WardLootens
Copy link

I can confirm that, with the 5.0.0-SNAPSHOT build, I was able to build and run the provider in Keycloak 21.
The existing config still works,
but indeed, I was no longer able to store the configuration from the Admin UI (I could view it, though)

@clement-dufaure
[FIX] Compatibility Keycloak 21
2b017ed 
Signed-off-by: Clément Dufaure <clement.dufaure@insee.fr>
@clement-dufaure clement-dufaure marked this pull request as ready for review June 21, 2023 09:09
@clement-dufaure clement-dufaure merged commit 5c69940 into InseeFr:master Jun 21, 2023
@clement-dufaure clement-dufaure mentioned this pull request Jun 23, 2023
Closed
@clement-dufaure clement-dufaure deleted the compatibility-kc-21 branch April 10, 2024 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clement-dufaure @mboisnard @WardLootens