Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

COMP: Fix CMake configuration for cmake versions without CMP0135 #4412

Merged
merged 1 commit into from
Jan 19, 2024
Merged

COMP: Fix CMake configuration for cmake versions without CMP0135 #4412

merged 1 commit into from
Jan 19, 2024

Conversation

SimonRit
Copy link

Fixes #4411

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

COMP: Fix CMake configuration for cmake versions without CMP0135
6a490be 
Fixes compilation error introduced by commit
7972041 for versions prior to CMake 3.24:

CMake Error at Utilities/ClangFormat/DownloadClangFormat.cmake:47 (cmake_policy):
  Policy "CMP0135" is not known to this version of CMake.
Call Stack (most recent call first):
  CMake/ITKModuleClangFormat.cmake:17 (include)
  CMake/ITKModuleMacros.cmake:9 (include)
  CMakeLists.txt:146 (include)
@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jan 19, 2024
@dzenanz dzenanz merged commit 8d1fac4 into InsightSoftwareConsortium:master Jan 19, 2024
11 of 12 checks passed
dzenanz added a commit to InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction that referenced this pull request Jan 23, 2024
@dzenanz
ENH: Update build-test-cxx.yml to latest ITK SHA
ad633d1 
This gives us changes from PRs:
InsightSoftwareConsortium/ITK#4404
InsightSoftwareConsortium/ITK#4412
among other things.
@dzenanz dzenanz mentioned this pull request Jan 23, 2024
Merged
@SimonRit SimonRit deleted the CMP0135 branch January 29, 2025 10:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake warning with CMP0135
2 participants
@SimonRit @dzenanz