ENH: Remove unused clang-format setup code #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installation of the clang-format tools is now performed in the file: Utilities/ClangFormat/DownloadClangFormat.cmake as an ExternalProject with the target of ClangFormat. The option for ITK_USE_CLANG_FORMAT was duplicated in CMake/ITKModuleClangFormat.cmake
hjmjohnson
added
type:Compiler
github-actions
bot
added
type:Infrastructure
|
Local test confirmed that the download paths for clang-format identified in CMake/ITKClangFormatSetup.cmake did nothing, but the download paths from Utilities/ClangFormat/DownloadClangFormat.cmake were present and useful after build. cmake -S /Users/johnsonhj/Dashboard/src/simplify-clang-format-setup -B cmake-build-test -DITK_USE_CLANG_FORMAT:BOOL=ON -DBUILD_TESTING:BOOL=ON |
dzenanz
approved these changes
Dec 3, 2024
|
Code change looks good, I have not tried running it locally. |
blowekamp
approved these changes
Dec 4, 2024
|
related to : #4565 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation of the clang-format tools
is now performed in the file:
Utilities/ClangFormat/DownloadClangFormat.cmake
as an ExternalProject with the target of ClangFormat.
The option for ITK_USE_CLANG_FORMAT was duplicated in CMake/ITKModuleClangFormat.cmake
PR Checklist