BUG: Remove empty tests. #5129
Merged
BUG: Remove empty tests. #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Bug
seanm
approved these changes
Jan 9, 2025
N-Dekker
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks @zivy Well spotted 👍
Just one remark: this is not really a bug fix, in my opinion. It's a clean-up action, which is a style improvement. (When an ITK user is interested to see the latest bug fixes that may affect their code, this is not one of them.)
So I would prefer a commit message subject line line:
STYLE: Remove empty GDCM tests
(I would also add the term "GDCM", to make the subject line a bit more specific.) See also the section "Commit Messages" in https://docs.itk.org/en/latest/contributing/index.html#commit-messages
Two of the GDCM tests were empty, did not test anything and were always successful (itkGDCMSeriesMissingDicomTagTest.cxx, itkGDCMSeriesReadImageWriteTest.cxx).
zivy
force-pushed
the
removeEmptyTests
branch
from
9226ff0 to
5c40f31
Compare
|
@N-Dekker Just changed the commit message subject line and force pushed. Surprisingly the PR subject line on GitHub remains the same after this change. |
dzenanz
approved these changes
Jan 10, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the GDCM tests were empty, did not test anything and were always successful (itkGDCMSeriesMissingDicomTagTest.cxx, itkGDCMSeriesReadImageWriteTest.cxx).