-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
TEST: Fix unexercised tests for large image read/write #5151
TEST: Fix unexercised tests for large image read/write #5151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing a pull request! 🙏
Welcome to the ITK community! 🤗👋☀️
We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖
This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.
ITK doesn't recognize |
7d057cb
to
83bfcfe
Compare
Updated the commit msg to use ENH |
83bfcfe
to
21e038c
Compare
CI runs into: |
Maybe a better solution would be to remove temporary files (at least for tests creating large temporaries) immediately after the test is successfully finished. But this is a lot of additional work, and could be its own issue. |
Also added a minimum memory guard so that the tests don't run on CI or other systems which cannot support high memory usage.
21e038c
to
259bd4d
Compare
I have increased the memory limit to 16GB. I think this should suffice for now? Removing the temp files, as you said can be a separate issue to track and could be applied across all tests. |
5df209f
into
InsightSoftwareConsortium:master
It |
CTest does not model the inputs or outputs of a test on disk. One would have to bake the cleanup into the tests themselves via wrapper scripts or similar. |
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.
Closes: #3703