Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Doxygen bib cleanup #5278

Merged
merged 5 commits into from
Mar 17, 2025
Merged

Doxygen bib cleanup #5278

merged 5 commits into from
Mar 17, 2025

Conversation

zivy
Copy link
Member

@zivy zivy commented Mar 16, 2025

No description provided.

@zivy zivy requested a review from dzenanz March 16, 2025 23:56
@github-actions github-actions bot added the area:Documentation Issues affecting the Documentation module label Mar 16, 2025
@zivy
Copy link
Member Author

zivy commented Mar 16, 2025

This is a continuation of the work on #3662

dzenanz
dzenanz reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the remote-module related references be added to the remote module in question?

@dzenanz
Copy link
Member

dzenanz commented Mar 17, 2025

commit 6fccc58 cannot be merged; it must start with one of the following prefixes: BUG: , COMP: , DOC: , ENH: , PERF: , STYLE: .

I guess that commits should have different first line (to easily distinguish them), or just squash them all.

zivy added 5 commits March 17, 2025 11:00
@zivy
DOC: Removing unused citation.
fbc7266 
The EUROCAST citation is incorrect (see notes in
itkIsoContourDistanceImageFilter.h and
itkFastChamferDistanceImageFilter.h). It is left in place in those
files because it was not clear where the publication appeared. It was
added to the doxygen bibliography in an automated fashion ignoring the
notes.
@zivy
DOC: Removing unused entry from bibliography file.
88ee08e 
This entry was mentioned in Ultrasound.remote.cmake which is not part
of the ITK documentation. It was added as a side effect of the
automated detection of references.
@zivy
DOC: Removing unused entry from bibliography file.
bff80a2 
This entry was mentioned in MorphologicalContourInterpolation.remote.cmake
which is not part of the ITK documentation. It was added as a side effect of the
automated detection of references.
@zivy
DOC: Removing unused entry from bibliography file.
270b3f5 
This entry was mentioned in Ultrasound.remote.cmake
which is not part of the ITK documentation. It was added as a side effect of the
automated detection of references.
@zivy
DOC: Removing unused entry from bibliography file.
41952f0 
This entry was mentioned in the repository README.md
which is not part of the ITK doxygen documentation. It was added as a
side effect of the automated detection of references.
@zivy zivy force-pushed the doxygenBibCleanup branch from 3da2dc5 to 41952f0 Compare March 17, 2025 15:03
@zivy
Copy link
Member Author

zivy commented Mar 17, 2025

Hi @dzenanz,
I just added the DOC, the action is the same for all of the removals so same title the explanation of why is in the longer commit message, so kept it as multiple commits. If you feel strongly about squashing them then I'll do that. Just let me know.

@dzenanz
Copy link
Member

dzenanz commented Mar 17, 2025

I don't feel strongly about it.

@dzenanz dzenanz requested a review from thewtex March 17, 2025 15:07
@zivy zivy merged commit f386c2d into InsightSoftwareConsortium:master Mar 17, 2025
7 checks passed
@zivy zivy deleted the doxygenBibCleanup branch March 17, 2025 16:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
area:Documentation Issues affecting the Documentation module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zivy @dzenanz