Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to ubuntu 24.04 and clang-format 18 #3

Closed

Conversation

blowekamp
Copy link
Member

No description provided.

@blowekamp blowekamp requested review from thewtex and hjmjohnson May 10, 2024 13:37
@blowekamp
Copy link
Member Author

blowekamp commented May 10, 2024

Currently the actions are just referring to "master". I am not sure how multiple versions can/should be supported.

InsightSoftwareConsortium/ITK#4651

@dzenanz
Copy link
Member

dzenanz commented Jul 18, 2024

With ITKv6 development started, maybe it is time for this and InsightSoftwareConsortium/ITK#3805 to move forward?

@thewtex
Copy link
Member

thewtex commented Dec 14, 2024

We can get the same version of clang-format used with ITK's clang-format configuration and pre-commit with:

clang_format_version=$(grep -A 1 "mirrors-clang-format" ITK.pre-commit-config.yaml | tail -n 1 | cut -d: -f2 | tr -d ' v')
pixi init
pixi add python
pixi add --pypi clang-format==$clang_format_version
export PATH=$PWD/.pixi/envs/default/bin/:$PATH

@blowekamp @hjmjohnson

@hjmjohnson
Copy link
Member

@thewtex I created a PR taking a different approach than what you suggest.

I think your suggestion is likely more flexible.

Would you mind pushing this forward?

clang-format github action tests are adding the the burden of keeping the remote modules up-to-date.

@hjmjohnson
Copy link
Member

@blowekamp See #7 as an update. I think @thewtex suggestion is probably better to exactly match what is used in ITK.

@dzenanz
Copy link
Member

dzenanz commented Jan 27, 2025

Superseded by #7.

@dzenanz dzenanz closed this Jan 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants