ENH: Add/update notebooks showing the pixel type support #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dzenanz
reviewed
May 25, 2023
dzenanz
approved these changes
May 25, 2023
ntatsisk
force-pushed
the
notebooks-pixel-types
branch
from
b80efd2 to
270c4dd
Compare
|
Hi @N-Dekker, can you also review the notebook to see if it covers the image type functionality added to itk-elastix? |
|
Thanks @ntatsisk I'll try it out using my latest conda environment 😃 |
N-Dekker
reviewed
May 26, 2023
N-Dekker
reviewed
May 26, 2023
N-Dekker
reviewed
May 26, 2023
N-Dekker
reviewed
May 26, 2023
|
No show stoppers, just minor suggestions. |
ntatsisk
force-pushed
the
notebooks-pixel-types
branch
from
270c4dd to
0a60fc5
Compare
N-Dekker
approved these changes
May 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itk-elastix
>=v0.17.0supports any scalar pixel type. This PR:ITK_Example09_PointSetAndMaskTransformationto read the masks asitk.UCtypesEDIT: Part of the code was based on reply #211 (comment) from @NHPatterson