Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENH: Bump Python package version to 0.18 #241

Merged
merged 1 commit into from
Aug 17, 2023
Merged

ENH: Bump Python package version to 0.18 #241

merged 1 commit into from
Aug 17, 2023

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Aug 16, 2023

Include initial transform improvements.

Include initial transform improvements.
@N-Dekker
Copy link
Collaborator

Please note that the added ElastixRegistrationMethod::SetExternalInitialTransform is very new, so it might still have some flaws. Use with care 😃

@thewtex
Copy link
Member Author

thewtex commented Aug 17, 2023

@N-Dekker yes, I make a note in the release notes that it is available for initial experimental testing. :-) Thanks!

@N-Dekker
Copy link
Collaborator

N-Dekker commented Aug 17, 2023

I'm preparing another extension to elastix, TransformixFilter::SetExternalTransform which would allow specifying any arbitrary ITK transform to be used by transformix. So it's basically complementary to ElastixRegistrationMethod::SetExternalInitialTransform Wonder if this should still be included with ITKElastix 0.18. Otherwise, it's also fine to me to have it in 0.19.

@dzenanz
Copy link
Member

dzenanz commented Aug 17, 2023

The ability to supply ITK transform and get it out of ElastixRegistrationMethod reduces the need for transformix. So I don't think there is any hurry for that functionality.

@N-Dekker
Copy link
Collaborator

The ability to supply ITK transform and get it out of ElastixRegistrationMethod

Honestly I did not yet add a GetExternalInitialTransform() member function to ElastixRegistrationMethod. Is any hurry for that one, GetExternalInitialTransform()? Obviously, it's pretty trivial to write (unlike SetExternalInitialTransform).

@dzenanz
Copy link
Member

dzenanz commented Aug 17, 2023

By "get ITK transform out of ElastixRegistrationMethod" I meant this:

comb_transform = elastix_object.GetCombinationTransform()
itk_transform = elastix_object.ConvertToItkTransform(comb_transform)

@tbirdso
Copy link
Collaborator

tbirdso commented Aug 17, 2023

If there are no objections I will go ahead and merge this shortly.

@tbirdso tbirdso merged commit 1839882 into main Aug 17, 2023
@N-Dekker
Copy link
Collaborator

By "get ITK transform out of ElastixRegistrationMethod" I meant this:

comb_transform = elastix_object.GetCombinationTransform()
itk_transform = elastix_object.ConvertToItkTransform(comb_transform)

Sorry @dzenanz ConvertToItkTransform does not yet support converting a combination transform that contains an "external" ITK transform. To be continued...!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants