Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v0.18.1: Upgrade elastix to 2023-09-18, converts external initial transforms #247

Conversation

N-Dekker
Copy link
Collaborator

Supports passing a transform retrieved by GetCombinationTransform() or GetNthTransform(n) to ConvertToItkTransform, when an external initial transform was specified before running the registration.

Also including various performance improvements.

Including:

pull request SuperElastix/elastix#946
commit SuperElastix/elastix@7bcb2b3
ENH: Write external initial transforms to ITK transform file

pull request SuperElastix/elastix#949
commit SuperElastix/elastix@601f465
ENH: ConvertToItkTransform should support external initial transform

pull request SuperElastix/elastix#950
commit SuperElastix/elastix@7e883bf
ENH: Add GetInitialTransform() and GetExternalInitialTransform()

pull request SuperElastix/elastix#959
commit SuperElastix/elastix@3979978
PERF: Speed up ComputeJacobianTerms access to vnl_sparse_matrix

pull request SuperElastix/elastix#960
commit SuperElastix/elastix@4d028f7
PERF: Speed up full, grid, sparse mask samplers by a local sampleVector

@dzenanz
Copy link
Member

dzenanz commented Sep 15, 2023

Could you also bump version number in setup.py? That way we can tag/release immediately after merging this.

@N-Dekker
Copy link
Collaborator Author

That way we can tag/release immediately after merging this.

Wouldn't it be sufficient to you to just locally use one of the wheels produced by the CI?

@dzenanz
Copy link
Member

dzenanz commented Sep 15, 2023

I want other people to be able to reproduce my work 😄 And having pip-installable package is super-useful for that.

There is a compile error: _deps/elx-src/Core/Main/itkElastixRegistrationMethod.hxx:43:10: fatal error: 'itkTransformFileWriter.h' file not found.

@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Sep 18, 2023

There is a compile error: _deps/elx-src/Core/Main/itkElastixRegistrationMethod.hxx:43:10: fatal error: 'itkTransformFileWriter.h' file not found.

Thanks @dzenanz I'm busy preparing a fix now.


Update -- here it is:

Supports passing a transform retrieved by `GetCombinationTransform()` or
`GetNthTransform(n)` to `ConvertToItkTransform`, when an _external_ initial
transform was specified before running the registration.

Also including various performance improvements.

Including:

  pull request SuperElastix/elastix#946
  commit SuperElastix/elastix@7bcb2b3
  ENH: Write external initial transforms to ITK transform file

  pull request SuperElastix/elastix#949
  commit SuperElastix/elastix@601f465
  ENH: `ConvertToItkTransform` should support external initial transform

  pull request SuperElastix/elastix#950
  commit SuperElastix/elastix@7e883bf
  ENH: Add GetInitialTransform() and GetExternalInitialTransform()

  pull request SuperElastix/elastix#959
  commit SuperElastix/elastix@3979978
  PERF: Speed up ComputeJacobianTerms access to `vnl_sparse_matrix`

  pull request SuperElastix/elastix#960
  commit SuperElastix/elastix@4d028f7
  PERF: Speed up full, grid, sparse mask samplers by a local sampleVector
@N-Dekker N-Dekker force-pushed the elastix-2023-09-14-ConvertToItkTransform-ExternalInitialTransform branch from 81d810c to b565286 Compare September 18, 2023 20:47
@thewtex
Copy link
Member

thewtex commented Sep 18, 2023

@N-Dekker what is meant by "external" here?

@N-Dekker
Copy link
Collaborator Author

what is meant by "external" here?

Thanks for asking, Matt, it's the topic of the following issue:

@N-Dekker N-Dekker changed the title ENH: Upgrade elastix to 2023-09-14, converts external initial transforms v0.18.1: Upgrade elastix to 2023-09-18, converts external initial transforms Sep 19, 2023
@dzenanz dzenanz merged commit cf7c2fe into InsightSoftwareConsortium:main Sep 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants