Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DOC: Add registration parameters notebook #27

Merged
merged 6 commits into from
Jan 22, 2020
Merged

DOC: Add registration parameters notebook #27

merged 6 commits into from
Jan 22, 2020

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jan 17, 2020

@mstaring @dzenanz @romangrothausmann please take a look.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@thewtex thewtex force-pushed the registration-parameters-notebook branch from e3e91ad to e76fbf0 Compare January 20, 2020 00:51
@thewtex thewtex force-pushed the registration-parameters-notebook branch from e76fbf0 to c3520b7 Compare January 20, 2020 00:59
dzenanz
dzenanz reviewed Jan 20, 2020
View reviewed changes
examples/0_HelloRegistrationWorld.ipynb
"outputs": [],
"source": [
"fixed = itk.imread('data/CT_2D_head_fixed.mha', itk.F)"
"First, let's load our **fixed image** and the image we will align to our fixed image, the **moving image**."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird sentence

dzenanz
dzenanz approved these changes Jan 20, 2020
View reviewed changes
@romangrothausmann
Copy link
Member

@mstaring @dzenanz @romangrothausmann please take a look.

Looks great! Will need some time before I can comment on details (but probably not specific to this PR).

@thewtex thewtex merged commit 732b516 into master Jan 22, 2020
@thewtex thewtex deleted the registration-parameters-notebook branch January 22, 2020 16:13
@romangrothausmann
Copy link
Member

Now better up to date with some details:
How can I get a specific parameter of a specific parameter map, e.g. the Metric of the parameter map 2? I.e. how to specify the ParameterKeyType of
http://elastix.isi.uu.nl/doxygen/classelastix_1_1ParameterObject.html#addbd52885b921baa8f737957178b13ec
for translating
https://github.com/romangrothausmann/elastix_scripts/blob/757b3b1add9494fc72aff70d1c85ce3218da0060/recRegStack.py#L241
from SE to ITKElastix?

@thewtex
Copy link
Member Author

thewtex commented Feb 11, 2020

@romangrothausmann #38 provides an example.

@ViktorvdValk ViktorvdValk mentioned this pull request Jan 5, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewtex @romangrothausmann @dzenanz