Skip to content

refactor: Replace APM API that uses reflection by a package private API #1388

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

refactor: Replace APM API that uses reflection by a package private API #1388

merged 2 commits into from
May 19, 2025

Conversation

AndrewAminInstabug
Copy link
Contributor

Description of the change

Replace APM API that uses reflection by a package private API

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: APM-22030

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 95.2% ✅
Android 50.3% ✅
iOS 51.6% ✅

Generated by 🚫 dangerJS against fc0cd3c

@AndrewAminInstabug AndrewAminInstabug merged commit 256e72a into dev May 19, 2025
9 of 11 checks passed
@AndrewAminInstabug AndrewAminInstabug deleted the refactor/replace-reflection branch May 19, 2025 10:02
kholood-ea added a commit that referenced this pull request May 27, 2025
@kholood-ea
Revert "Merge pull request #1388 from Instabug/refactor/replace-refle…
5a858dd 
…ction"

This reverts commit 256e72a, reversing
changes made to 196b481.
kholood-ea added a commit that referenced this pull request May 27, 2025
@kholood-ea
Revert "Merge pull request #1388 from Instabug/refactor/replace-refle…
bea6429 
…ction" (#1396)

This reverts commit 256e72a, reversing
changes made to 196b481.
MoKamall pushed a commit that referenced this pull request Jun 2, 2025
@kholood-ea @MoKamall
Revert "Merge pull request #1388 from Instabug/refactor/replace-refle…
79e4a26 
…ction" (#1396)

This reverts commit 256e72a, reversing
changes made to 196b481.
kholood-ea added a commit that referenced this pull request Jul 1, 2025
@kholood-ea
feat: respect be network body limit (#1397)
c668f3b 
* chore(ios): add respect BE network body limit custom build

* feat(ios): add getNetworkBodyMaxSize API

* feat:add getNetworkBodyMaxSize API

* chore(android): add respect network body limit snapshot

* chore(ios): sync pdfile.lock

* Revert "Merge pull request #1388 from Instabug/refactor/replace-reflection"

This reverts commit 256e72a, reversing
changes made to 196b481.

* feat(android): add getNetworkBodyMaxSize API

* feat:add feature flag change listener for android

* chore: fix sync_generated_files CI job

* feat(ios): add getNetworkBodyMaxSize API

* chore: add change log

* Revert duplicate "feat(ios): add getNetworkBodyMaxSize API"

This reverts commit ef8710e.

* chore: edit a change log

* chore: update test cases titles
kholood-ea added a commit that referenced this pull request Jul 1, 2025
@kholood-ea
feat: respect be network body limit (#1397)
83c5b9e 
* chore(ios): add respect BE network body limit custom build

* feat(ios): add getNetworkBodyMaxSize API

* feat:add getNetworkBodyMaxSize API

* chore(android): add respect network body limit snapshot

* chore(ios): sync pdfile.lock

* Revert "Merge pull request #1388 from Instabug/refactor/replace-reflection"

This reverts commit 256e72a, reversing
changes made to 196b481.

* feat(android): add getNetworkBodyMaxSize API

* feat:add feature flag change listener for android

* chore: fix sync_generated_files CI job

* feat(ios): add getNetworkBodyMaxSize API

* chore: add change log

* Revert duplicate "feat(ios): add getNetworkBodyMaxSize API"

This reverts commit ef8710e.

* chore: edit a change log

* chore: update test cases titles
kholood-ea added a commit that referenced this pull request Jul 3, 2025
@kholood-ea
Release/v15.0.1 (#1402)
5c8f2cf 
* chore(android):  bump android sdk to v15.0.1

* chore: bump android sdk to v15.0.1

* chore(ios): bump SDK to v15.1.1

* chore: add changelog item

* chore: fix sync_generated_files CI job

* chore: fix plugin version

* feat: respect be network body limit (#1397)

* chore(ios): add respect BE network body limit custom build

* feat(ios): add getNetworkBodyMaxSize API

* feat:add getNetworkBodyMaxSize API

* chore(android): add respect network body limit snapshot

* chore(ios): sync pdfile.lock

* Revert "Merge pull request #1388 from Instabug/refactor/replace-reflection"

This reverts commit 256e72a, reversing
changes made to 196b481.

* feat(android): add getNetworkBodyMaxSize API

* feat:add feature flag change listener for android

* chore: fix sync_generated_files CI job

* feat(ios): add getNetworkBodyMaxSize API

* chore: add change log

* Revert duplicate "feat(ios): add getNetworkBodyMaxSize API"

This reverts commit ef8710e.

* chore: edit a change log

* chore: update test cases titles

* chore: fix CI job
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MoKamall MoKamall MoKamall approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AyaMahmoud148 AyaMahmoud148 AyaMahmoud148 approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndrewAminInstabug @InstabugCI @MoKamall @ahmedAlaaInstabug @AyaMahmoud148