Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature/add numba rc support #1001

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Feature/add numba rc support #1001

merged 1 commit into from
Apr 17, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 14, 2023 •
edited by diptorupd
Loading

Resolves numba version parsing that contains suffixes. One of the blockers to test all the compatibility issues with numba 0.57.0rc1.
#1000

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Apr 14, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_numba_rc_support branch from dae8b81 to adb71d6 Compare April 14, 2023 22:06
@ZzEeKkAa ZzEeKkAa mentioned this pull request Apr 14, 2023
Merged
5 tasks
@diptorupd
Copy link
Contributor

@ZzEeKkAa I suggest moving the logic into a function and adding some unit test cases (test_numba_version_parsing).

@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_numba_rc_support branch 7 times, most recently from 0e0783b to 584d8f0 Compare April 17, 2023 15:08
@ZzEeKkAa ZzEeKkAa enabled auto-merge April 17, 2023 15:09
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_numba_rc_support branch 3 times, most recently from f3c7188 to d9c84f8 Compare April 17, 2023 15:33
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_numba_rc_support branch from d9c84f8 to 78022cc Compare April 17, 2023 15:43
@ZzEeKkAa ZzEeKkAa merged commit 4218ae1 into main Apr 17, 2023
@ZzEeKkAa ZzEeKkAa deleted the feature/add_numba_rc_support branch April 17, 2023 21:45
github-actions bot added a commit that referenced this pull request Apr 17, 2023
@github-actions
Merge pull request #1001 from IntelPython/feature/add_numba_rc_support
2fdaeaf 
Feature/add numba rc support 4218ae1
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd