Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Overloads for an AtomicRef class and fetch_add method #1257

Merged
merged 11 commits into from
Dec 28, 2023

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Dec 27, 2023

  • Have you provided a meaningful PR description?

Adds a new AtomicRef class to the experimental kernel_iface module to mimic sycl::atomic_ref class. The class includes Python functions to simulate the atomic fetch_* functions in SYCL.

The AtomicRef class is also overloaded and an overloaded implementation is provided for the class constructor and the fetch_add method was also added.

UPD: one bug was introduced/discovered along with a workaround: #1262

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from ZzEeKkAa December 27, 2023 04:54
@diptorupd diptorupd force-pushed the experimental/atomic_ref branch 4 times, most recently from 3af9af5 to f6bc84c Compare December 27, 2023 22:09
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@diptorupd diptorupd force-pushed the experimental/atomic_ref branch from f6bc84c to b3b19d8 Compare December 27, 2023 22:29
@diptorupd diptorupd force-pushed the experimental/atomic_ref branch from b3b19d8 to 6497c26 Compare December 28, 2023 02:30
@ZzEeKkAa ZzEeKkAa force-pushed the experimental/atomic_ref branch from 6497c26 to 594b8b7 Compare December 28, 2023 19:25
@ZzEeKkAa ZzEeKkAa force-pushed the experimental/atomic_ref branch from 594b8b7 to 147da67 Compare December 28, 2023 19:28
@ZzEeKkAa ZzEeKkAa enabled auto-merge December 28, 2023 19:30
@ZzEeKkAa ZzEeKkAa merged commit 474212e into main Dec 28, 2023
33 of 41 checks passed
@ZzEeKkAa ZzEeKkAa deleted the experimental/atomic_ref branch December 28, 2023 19:56
github-actions bot added a commit that referenced this pull request Dec 28, 2023
Overloads for an AtomicRef class and fetch_add method 474212e
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants