Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

delete some files in pd_series_ext.py #795

Merged
merged 2 commits into from
Apr 9, 2020
Merged

delete some files in pd_series_ext.py #795

merged 2 commits into from
Apr 9, 2020

Conversation

Rubtsowa
Copy link
Contributor

@Rubtsowa Rubtsowa commented Apr 8, 2020

No description provided.

densmirn
densmirn approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@densmirn densmirn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the PR if it's ok that most of tests in the "old style" including tests on Series.str.split in test_hiframes fail.

@AlexanderKalistratov
Copy link
Collaborator

@densmirn so are split tests actually skipped?

@densmirn
Copy link
Contributor

densmirn commented Apr 9, 2020

@densmirn so are split tests actually skipped?

Yes, they are. The test I talked about before is on str.split (not Series.str.split).

@AlexanderKalistratov AlexanderKalistratov merged commit 4827e98 into IntelPython:master Apr 9, 2020
@AlexanderKalistratov
Copy link
Collaborator

Just thought that we need to delete tests too

@Rubtsowa Rubtsowa deleted the delete_hiframes branch April 10, 2020 05:11
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@densmirn densmirn densmirn approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@Vyacheslav-Smirnov Vyacheslav-Smirnov Awaiting requested review from Vyacheslav-Smirnov

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rubtsowa @AlexanderKalistratov @densmirn