Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI: Add aarch64-linux #1612

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

sgillespie
Copy link
Contributor

Description

Add aarch64-linux support for nix builds

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie mentioned this pull request Jan 22, 2024
9 tasks
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch from 2678124 to 9d44f32 Compare January 24, 2024 18:20
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch from 9d44f32 to fa30421 Compare May 21, 2024 18:21
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch 3 times, most recently from 2df5ea5 to e12744d Compare June 14, 2024 16:02
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch 3 times, most recently from dc1dcf0 to 1615d93 Compare June 17, 2024 19:26
@sgillespie sgillespie marked this pull request as ready for review June 17, 2024 19:29
angerman
angerman previously approved these changes Jun 18, 2024
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although we should fix hsc2hs and figure out why formulou breaks. However as that is likely unnecessary as a cross compiled tool, I think this is ok.

Cmdv
Cmdv previously approved these changes Jun 28, 2024
@sgillespie sgillespie dismissed stale reviews from Cmdv and angerman via e444ad7 July 18, 2024 12:29
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch from 1615d93 to e444ad7 Compare July 18, 2024 12:29
@sgillespie sgillespie requested a review from a team as a code owner July 18, 2024 12:29
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch from e444ad7 to cce5c78 Compare July 18, 2024 12:31
@sgillespie sgillespie force-pushed the feature/aarch64-linux branch from cce5c78 to 5225297 Compare July 18, 2024 12:44
@sgillespie sgillespie merged commit ec38417 into IntersectMBO:master Jul 18, 2024
10 of 23 checks passed
@sgillespie sgillespie deleted the feature/aarch64-linux branch July 18, 2024 23:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants