Add key raw serialisation instances, and IsString #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SerialiseAsRawBytes instances for all the keys (vkey and skey). Also provide more helpful Show and IsString instances for all the key types, so that quick examples are easier to construct and work with in ghci. Show will render in hex format without any extra constructor, and the same syntax will work for construction using IsString. Also add more Bech32 instances for things agreed in the draft CIP.
dcoutts
requested review from
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
Jimbo4350
reviewed
Jul 14, 2020
| (Crypto.HD.xprv bs) | ||
|
|
||
| instance SerialiseAsBech32 (VerificationKey ByronKey) where | ||
| bech32PrefixFor _ = "addr_xvk" |
There was a problem hiding this comment.
what does the x stand for here?
There was a problem hiding this comment.
eXtended
|
bors merge |
Build succeeded |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SerialiseAsRawBytes instances for all the keys (vkey and skey).
Also provide more helpful Show and IsString instances for all the key
types, so that quick examples are easier to construct and work with in
ghci. Show will render in hex format without any extra constructor, and
the same syntax will work for construction using IsString.
Also add more Bech32 instances for things agreed in the draft CIP.