Add ScriptContext test #6959
Open
Add ScriptContext test #6959
+3,970
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This reverts commit 717d93f.
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
commented
Mar 24, 2025
| {-# LANGUAGE OverloadedStrings #-} | ||
| {-# LANGUAGE TemplateHaskell #-} | ||
| {-# LANGUAGE TypeApplications #-} |
There was a problem hiding this comment.
I don't understand why Data-backed Marlowe is slightly faster now. The only relationship I can think of is that maybe it uses code from this module and adding these two extensions somehow made the compiler generate code which is slightly more optimal?
There was a problem hiding this comment.
After talking to @zliu41, and seeing that other tests have also been impacted, it's most likely from the two member' and insert' functions being exported, but it remains to be seen what exactly is going on with the Haskell Core. Anyway, we're lucky that the performance changes work in our favor.
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/IntersectMBO/plutus-private/issues/1479
The
AsDataversion is actually slightly better (in script size) than the manually optimised version! I am not entirely sure why, since I tried multiple versions of the manually optimised one, and this was the best one.