-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Pipeline2 #36
Pipeline2 #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 82.35% 70% -12.36%
Complexity 3 3
==========================================
Files 2 3 +1
Lines 51 60 +9
==========================================
Hits 42 42
- Misses 9 18 +9
Continue to review full report at Codecov.
|
Hey @Natkeeran, thanks for throwing this up. You've successfully pulled together an Alpaca subproject, got it integrated into the build system, and got a feature going. That's impressive. I think it's great you took this bull by the horns. I'll give this a deeper look and take it for a spin. If it floats, we'll go ahead and pull this in. I'll add the changes we were talking about in IRC in a subsequent PR. |
@dannylamb Thanks Danny. Please point me to some examples of tests, and I can follow that and add them as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 It builds. Feature installs. I made test routes and it runs (after changing config, of course).
Let's bring this in and we'll merge it with broadcaster in a subsequent issue.
And don't worry about tests right now. Codecov.io is unhappy but I'm making an executive decision. You're not doing anything that isn't already covered by existing camel tests.
@Natkeeran unit testing camel routes can be a real pain -- for a lot of our code at Amherst, I just skip unit testing altogether and opt for really, really simple camel routes: the sort of routes that don't (IMO) need testing; sort of like this route here. The important bit of testing for camel stuff comes in with Pax Exam, which is way more complicated that unit tests. Plus, I find that the integration testing I can do with pax exam is way more useful than unit tests. You can find some examples here: https://gitlab.amherst.edu/acdc/repository-extension-services/tree/master/acrepo-itests and here: https://github.com/fcrepo4-exts/fcrepo-camel-tests |
GitHub Issue: (link)
What does this Pull Request do?
What's new?
How should this be tested?
One way to test this is to create a sample log or file route. An example is provided below. Can verify that the component is working via logs!
<< People with better camel expertise, please provide additional instructions >>
Additional Notes:
Danny noted that Pipeline or boradcast could be re-factored into one component with ExchangePattern option being passed in as a header to RoutlingSlip. Needs further research.
This is pretty much Danny's code, I had a chance to understand it.
Interested parties
@dannylamb
@Islandora-CLAW/committers