Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove calls to Gemini. #78

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented May 3, 2021

GitHub Issue: Islandora-Devops/isle-dc#132

What does this Pull Request do?

Removes calls to Gemini

What's new?

Less code.

How should this be tested?

I think build tests should take care of it.

Interested parties

@dannylamb @whikloj 👋

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #78 (f934bd0) into dev (762a433) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

❗ Current head f934bd0 differs from pull request most recent head 92df03f. Consider uploading reports for the commit 92df03f to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #78      +/-   ##
============================================
- Coverage     90.00%   89.56%   -0.44%     
+ Complexity       73       70       -3     
============================================
  Files            10       10              
  Lines           300      297       -3     
  Branches          1        1              
============================================
- Hits            270      266       -4     
- Misses           29       30       +1     
  Partials          1        1              
Impacted Files Coverage Δ Complexity Δ
...slandora/alpaca/indexing/fcrepo/FcrepoIndexer.java 94.54% <100.00%> (+1.62%) 5.00 <0.00> (-1.00) ⬆️
...ora/alpaca/support/event/AS2AttachmentContent.java 86.36% <0.00%> (-13.64%) 13.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762a433...92df03f. Read the comment docs.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind just burning the entire {{file.stream}} route while you're in there? 🔥 🔥 🔥

The cruft you're clearing is a glaring oversight on my part 😅 Thanks.

@dannylamb
Copy link
Contributor

There's also references to {{file.stream}} in the config here and here to clear out once you delete that route.

@ruebot
Copy link
Member Author

ruebot commented May 3, 2021

@dannylamb totally! I was unsure if I should leave it or not.

ruebot added a commit to yorkulibraries/yudl-playbook that referenced this pull request May 5, 2021
- Remove Gemini
- Resolves #33
- Resolves #35
- Update README
- Update certbot task to run differently on staging and production
- Install grok role on all hosts
- Install database role on all hosts
- Remove triplestore from Karaf and Alpace roles
- Install Alpaca with York University fork (no Gemini): Islandora/Alpaca#78
- Install Tomcat role on all hosts
- Remove Blazegraph references from Tomcat role
- Setup templates for each host for Tomcat services
- Add production variables
- Remove RedHat functionality
- Update perms_fix to link sites/default/files to production storage
- Add production Apache configs
- Update webserver role to install Drupal database correctly
@dannylamb
Copy link
Contributor

Testing this now

@dannylamb
Copy link
Contributor

This builds and deploys just fine. I ingested some content and the binary and rdf made it to Fedora no problem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants