Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Taxonomy Term updates not propagating to Fedora #46

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Fix Taxonomy Term updates not propagating to Fedora #46

merged 4 commits into from
Jan 31, 2020

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: Islandora/documentation#1417

What does this Pull Request do?

Adds missing changed mapping to all the rdf mappings:

  changed:
    properties:
      - 'schema:dateModified'
    datatype_callback:
      callable: 'Drupal\rdf\CommonDataConverter::dateIso8601Value'

What's new?

  • Added changed mapping to rdf mappings
  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? No.

How should this be tested?

  • Create a Person (or any other Taxonomy term provided by controlled_access_terms): The person appears in Fedora
  • Update the person: The changes do not appear in Fedora (and Milliner complains)
  • Apply the PR && import the feature changes
  • Update the person again: The changes do appear in Fedora (and no Milliner complaints)

Interested parties

@bseeger and @dannylamb

dannylamb
dannylamb approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested and works. I can confirm behaviour before and after this PR.

@dannylamb dannylamb merged commit ea3897f into Islandora:8.x-1.x Jan 31, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the issue-1417 branch January 31, 2020 21:26
@dannylamb
Copy link
Contributor

I pushed this to the release branch as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dannylamb dannylamb dannylamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seth-shaw-unlv @dannylamb