-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Documentation audit for 7.x-2.x #537
Comments
Here is some help if somebody wants to tackle it:
|
@ruebot some repositories have 8.x.-1.x, master, or both branches. In the case where there are both branches, should I mention that in contributing.md to base your work off of master or off of 8.x-1.x? |
@kimpham54 just list any repo that you have a question about, and we address them one-by-one. |
@kimpham54 can you gather links to all your pull requests here in a comment, and let us know when you're ready for us to review them all. You can edit the comment if need be. |
cleanup tasks for CONTRIBUTING.md (will continue to be updated):
additional notes when auditing documentation: |
I'm guessing that if it is, this does not apply to every repository but only the CLAW repo? From https://github.com/Islandora-CLAW/CLAW/blob/master/CONTRIBUTING.md#create-a-pull-request. |
|
|
@kimpham54 I'm fine with that. But, this might become a gotcha in the future when updating the document again. @manez, what do you think? |
I'd prefer to keep it generic if there's any way we can rephrase that. Just looking at how much variation has crept into something as simple as the LICENCE file on the 7.x stack, which is supposed to be identical, the fewer moving parts we maintain in these every-repo-has-one docs, the better. |
@kimpham54 we had some Islandora-CLAW GitHub org changes over the last week, so there should be less work here. How are things going on your end with this ticket? |
@kimpham54 ping. |
@ruebot sorry, just got back from vacation and didn't have my laptop. i'll be sending PRs shortly |
@ruebot @manez trying to describe forking a repository in a generic way:
The repositories in Islandora-CLAW currently use either master or 8.x-1.x. |
That can be a personal or institutional depending on CLAs. You could just say something along the lines of making sure your work begins with syncing with the remote and link to this: https://help.github.com/articles/syncing-a-fork/
All Drupal modules use the Drupal version branch convention. Everything else is master. |
@ruebot @manez Islandora/Alpaca#37 is ready for review. I've closed all other PRs for now. If the CONTRIBUTING.md looks good, I will start creating pull requests for the other repositories with the same CONTRIBUTING.md |
* Partially addresses Islandora/documentation#537
* Change default name, and bump memory * Partially addresses Islandora/documentation#537 * readme * readme
@ruebot none of the repositories now mention 7.x-2.x, with the exception of https://github.com/Islandora-CLAW/CLAW/blob/master/docs/contributing/templates/closeCommitterVote.txt#L1 and https://github.com/Islandora-CLAW/CLAW/blob/master/docs/contributing/templates/committerVote.txt#L1 |
@kimpham54 those need to stay as is. |
@kimpham54 you can proceed with the Hypercube PR now. |
* Ignore web/sites/*/settings.php and web/sites/*/settings.local.php by default (drupal-composer#178) * Prefix paths with a slash (drupal-composer#245) * Update dev dependencies (SA-CORE-2017-001) https://www.drupal.org/SA-2017-001 * Fix typo in README.md Fixes drupal-composer#251 * Adding Islandora dependencies (#2) * Adding Islandora dependencies Part of Islandora/documentation#474 * Adding the github for claw-jsonld * Removing requirement on islandora/islandora islandora/islandora_collection requires it already. * Removes repository/vcs entries from composer.json and adds requirements (#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements * Revert to drupal/rdf_ui 1.x-dev version (#4) * ISSUE-513 Fixes Drupal 8.1.x compatibility issue with drupal/rdf_ui by setting version fixed to 1.x-dev * Lock package versions to stuff we know work * Adding Islandora dependencies (#2) * Adding Islandora dependencies Part of Islandora/documentation#474 * Adding the github for claw-jsonld * Removing requirement on islandora/islandora islandora/islandora_collection requires it already. * Removes repository/vcs entries from composer.json and adds requirements (#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements * Remove and ignore composer.lock; Resolves Islandora/documentation#530 * Pull Request Template (#8) * address Islandora/documentation#537 (#9)
@ruebot updated #537 (comment) |
@kimpham54 thanks for all your work this!! |
@ruebot thanks for putting up with my million fake PRs |
We need to audit the
docs
directory for any mention of 7.x-2.x, and if it exists replace it with Islandora CLAW.The text was updated successfully, but these errors were encountered: