Issue #387 #395
Issue #387 #395
Conversation
| @@ -8,11 +8,5 @@ if [ -f "$HOME_DIR/islandora/install/configs/variables" ]; then | |||
| . "$HOME_DIR"/islandora/install/configs/variables | |||
| fi | |||
|
|
|||
| cd "$HOME_DIR" | |||
| git clone https://github.com/Islandora-CLAW/Alpaca.git | |||
| cd Alpaca | |||
There was a problem hiding this comment.
So, we're going to continue to use sub-modules for the install? If so, I'm still 👎 on this.
There was a problem hiding this comment.
If the install we provide with the source code doesn't actually work on the source code it's shipped with, then why is it even here? I say we pull it out to another repo at that point.
If we must dodge the submodules, then in the very least can we push the git remote and branch to variables? I'm using the submodules to avoid having to constantly edit my build scripts when testing installs of code that hasn't been accepted yet.
There was a problem hiding this comment.
It seems like the solution to this issue is to figure out a way to update the CLAW repo every time a commit goes into any of the other repos.
That...seems stupid. But I'm not honestly sure that git submodules serve any useful purpose now that I've used them and see their limitations.
Perhaps we are using them wrong? I can't understand why they can't refer to HEAD and auto-update until we cut a release at which time we pin them to a specific commit.
There was a problem hiding this comment.
Would require a webhook to auto-update. I guess I'll just live with mangling the install script everytime I have to test un-merged changes...
I'm moving it back to point to head. Please let's just get this merged. I've got tons of follow up to this.
|
Done. Please merge. We'll figure out what to do with submodules later. |
|
👍 - @ruebot if your concerns are addressed, please merge. |
Pruned alpaca install for #387.
See Islandora/Alpaca#17 as well.