fixed return element #146
Merged
fixed return element #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondjimbond
approved these changes
Oct 15, 2018
|
@DonRichards Thanks for merging! I lost track of this one. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
What does this Pull Request do?
The ajax callback triggered by changing the Lame path doesn't work.
What's new?
Fixes the return element so the callback works.
How should this be tested?
Navigate to example.com/admin/islandora/solution_pack_config/audio
Change the path to Lame to something wrong -
Click outside the text box
The message will indicate that Lame can't be found
Fix the path and click again.
Interested parties
@Islandora/7-x-1-x-committers