-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Version 3.0 WIP #135
Merged
Merged
Version 3.0 WIP #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapAsync method now accepts a second argument with a component to display
ItalyPaleAle
force-pushed
the
v3.0-wip
branch
from
September 19, 2020 21:32
518664c
to
81a4a55
Compare
ItalyPaleAle
force-pushed
the
v3.0-wip
branch
from
September 19, 2020 21:43
410eacc
to
56f4f47
Compare
ItalyPaleAle
force-pushed
the
v3.0-wip
branch
from
September 19, 2020 21:45
56f4f47
to
870059e
Compare
Amazing! ❤️ |
Fixes #131 Credits: @matt-psaltis
This also includes a refactoring to leverage async/await more Fixes #125
1. If the page changes while a dynamic route is loading, do not display it when ready 2. Clone the detail object passed to the route loaded event for the placeholder component
ItalyPaleAle
force-pushed
the
v3.0-wip
branch
4 times, most recently
from
September 20, 2020 23:44
d0fc936
to
bf7bf37
Compare
ItalyPaleAle
force-pushed
the
v3.0-wip
branch
from
September 20, 2020 23:44
bf7bf37
to
4a0b5e6
Compare
Merged! Version 3.0 is coming out now 🚀 🎉 😄 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the work being done on the upcoming version 3.0.
Breaking changes:
wrap
method exported bysvelte-spa-router
is now considered deprecated and using it will throw a warning; it will be removed in a future version. Please upgrade to the newwrap
method exported bysvelte-spa-router/wrap
, which also supports dynamically-imported routes. See the documentation for route pre-conditions.nextTickPromise
, which was already deprecated, has been removedNew features:
Changes:
tick
method from Svelte rather than re-implementing it. The methodnextTickPromise
, which was already deprecated, has been removed.Fixes:
TODO: