Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Default emojis returning a 404 image #113

Closed
balonsom opened this issue Feb 7, 2023 · 5 comments
Closed

Default emojis returning a 404 image #113

balonsom opened this issue Feb 7, 2023 · 5 comments
Assignees
Labels
bug/confirmed reproduceable bugs

Comments

@balonsom
Copy link

balonsom commented Feb 7, 2023

The src of the images for default emojis like :heart: are returning a 404 error.

image

As far as I've seen, the CDN is working fine but instead of using URL of code points https://twemoji.maxcdn.com/v/latest/svg/2764-fe0f.svg it works if only the first filename part is sent https://twemoji.maxcdn.com/v/latest/svg/2764.svg.

Maybe twemoji libary docs have more info about this.

@ItzDerock ItzDerock added the bug/unconfirmed Something isn't working, but haven't been reproduced label Feb 7, 2023
@ItzDerock
Copy link
Owner

Will look into this.
https://github.com/ItzDerock/discord-html-transcripts/blob/master/src/utils/utils.ts#L17
Issue probably originates from this function.

@ItzDerock ItzDerock added bug/confirmed reproduceable bugs and removed bug/unconfirmed Something isn't working, but haven't been reproduced labels Feb 11, 2023
@ItzDerock
Copy link
Owner

able to reproduce, looking into how I can fix this.

@ItzDerock
Copy link
Owner

ItzDerock commented Mar 6, 2023

Looked into this a bit. I think all I need to do is implement the grabTheRightIcon(...) function from twemoji into discord-html-transcripts.

I'll implement this soon and test it out.

@ItzDerock ItzDerock self-assigned this Mar 6, 2023
@ItzDerock ItzDerock added the fix/in-progress Fixes in progress label Mar 6, 2023
ItzDerock added a commit that referenced this issue Mar 18, 2023
@ItzDerock
Copy link
Owner

Issue should be fixed with that commit. Note that emojis released in Unicode/Emoji 15 still will not work as some of the people on the team to release that were laid off.

@ItzDerock ItzDerock added fix/next-release Fix incoming in the next release and removed fix/in-progress Fixes in progress fix/next-release Fix incoming in the next release labels Mar 18, 2023
@ItzDerock
Copy link
Owner

released in 3.1.4

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug/confirmed reproduceable bugs
Projects
None yet
Development

No branches or pull requests

2 participants