Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add 'files' field to package.json #398

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

nktnet1
Copy link

@nktnet1 nktnet1 commented Oct 23, 2023

Hello,

In version 3.0.0, the code tab on npm contains many redundant files:

node-libcurl-3 0 0

From what I can see, only

  "files": [
    "binding.gyp",
    "dist",
    "scripts",
    "src"
  ],

is necessary to install node-libcurl.

For example, I made a fork of node-libcurl called easy-libcurl@1.0.3 containing the "files" attribute above:

easy-libcurl@1.0.3

which installs and runs fine. While easy-libcurl only exports the Easy interface, I doubt this will have an effect on which files are necessary for the distributable.

This change will reduce the package size when installed. Hope it helps in some way :).

Thank you again for your work on node-libcurl!

Copy link
Owner

@JCMais JCMais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! It is missing some other required files, but I will add these directly

@JCMais JCMais merged commit e1071ba into JCMais:develop Feb 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants