Skip failing test due to bug in readr. On the bright side, my fix for

the the other readr bug has now made it into a release so we can put those tests back in.
JGCRI · Nov 15, 2020 · 5fe9ea0 · 5fe9ea0
1 parent f97c8d0
commit 5fe9ea0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/tests/testthat/test_querymi.R b/tests/testthat/test_querymi.R
@@ -26,7 +26,6 @@ test_that('queries can be parsed', {
 
 
 test_that('trying to connect to an invalid database produces an error.', {
-    skip("Skip due to bug tidyverse/readr#963")
               expect_error({dbc <-
                   suppressWarnings(localDBConn(SAMPLE.GCAMDBLOC,
                                                'nonexist_basexdb'))},
@@ -69,6 +68,7 @@ test_that('warnings issued appropriately for empty tables', {
                                                regions='Canada')},
                              'Query returned empty table')
               expect_equal(nrow(rslt), 0)
+              skip("Skip due to readr bug which doesn't drop whitespace in an empty file then warns about it.")
               expect_silent({rslt <- runQuery(conn, queries[[4]]$query,
                                               regions='Canada',
                                               warn.empty = FALSE)})
@@ -160,9 +160,8 @@ test_that('listScenariosInDB works on local DB', {
 })
 
 test_that('listScenariosInDB gracefully gives empty table when no scenarios available', {
-    skip("Skip due to bug tidyverse/readr#963")
     missing_conn <- localDBConn(SAMPLE.GCAMDBLOC, "missing_basexdb", validatedb=FALSE)
-    expect_warning({rslt <- listScenariosInDB(missing_conn)})
+    expect_silent({rslt <- listScenariosInDB(missing_conn)})
 
     expect_equal(nrow(rslt), 0)
 })