Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make pre-commit hook working with Windows path separator #359

Conversation

Kevinrob
Copy link
Contributor

@Kevinrob Kevinrob commented May 15, 2020

I have installed the pre-commit hook on my setup.
Windows can run bash script (thank to WSL?) but path separators don't match and I get:

PS C:\Users\kevin\sample\> git commit -m "test"
Running ktlint over these files:
app/src/main/java/com/qoqa/qoqa/views/view/BadgeView.kt
Completed ktlint run.
Completed ktlint hook.
[master b7a98c7fa] test
 1 file changed, 1 insertion(+)

pre-commit script show edited files but ktlint doesn't run on it.

@Kevinrob Kevinrob marked this pull request as ready for review May 15, 2020 11:14
Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harrytalbot
Copy link

Is this scheduled for merge and release soon? Sounds like it should fix #270

@Tapchicoma
Copy link
Collaborator

Yes, we will try to do a new release this week.

Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tapchicoma Tapchicoma merged commit 7f42af5 into JLLeitschuh:master Jul 8, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants